-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgp: T6151: Allow configuration of disable-ebgp-connected-route-check #3212
Conversation
@Mergifyio backport sagitta |
✅ Backports have been created
|
@@ -1,7 +1,7 @@ | |||
<!-- include start from bgp/neighbor-disable-connected-check.xml.i --> | |||
<leafNode name="disable-connected-check"> | |||
<properties> | |||
<help>Disable check to see if eBGP peer address is a connected route</help> | |||
<help>Allow peerings between eBGP peer using loopback address</help> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But In the real life (as I remember) it doesn’t related loopback only interface.
Can confuse users to use loopback only
For example dummy and loopback work different way.
@dmbaturin any pros/cons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe simply use: loopback/dummy interface address
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move loopback/dummy interface address
, Do you agree ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fett0 yeah, please change to: Allow peerings between eBGP peer using loopback/dummy interface address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be a tunnel interface or VIF? :)
And yes, loopback/dummy looks better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect ! I'll add a extend explanation in our documentation , just it case .
Allow configuration of disable-ebgp-connected-route-check when the next-hop is learned not connected.
Change Summary
Types of changes
Related Task(s)
https://vyos.dev/T6151
Related PR(s)
Component(s) name
bgp
Proposed changes
How to test
vyos command :
Smoketest result
Checklist: